fix(openai-agents): capture system instructions from Response object#4284
Closed
nagkumar91 wants to merge 1 commit into
Closed
fix(openai-agents): capture system instructions from Response object#4284nagkumar91 wants to merge 1 commit into
nagkumar91 wants to merge 1 commit into
Conversation
…pen-telemetry#4188) When using the Responses API, instructions are passed separately and stored on response.instructions rather than as role="system" input messages. This adds a fallback to read response.instructions for gen_ai.system_instructions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4188
Problem: When using the Responses API (default in OpenAI Agents SDK), agent
instructionsare passed as a separate parameter toresponses.create(instructions=...)— NOT asrole: "system"messages in the input. TheResponseobject stores these on its.instructionsattribute. However,_collect_system_instructions()only scans input messages forrole in {"system", "ai"}, so instructions were never captured ingen_ai.system_instructions.Fix: In
_build_content_payload()forResponseSpanData, after the existing input-message-based system instruction collection, add a fallback that readsresponse.instructions:This works for both Responses API and Chat Completions API (which already worked via input messages).
Testing: Added unit test with mock Response object containing
.instructions.Type of Change